Hi @sombralibre

Thanks for the PR!

Can you give the version number in Chart.yaml a minor bump?

Hi @sombralibre,

Apologies for not mentioning this in my initial review.

I think that the nodePort customisation should be implemented slightly differently, taking into consideration the other useful customisation options for http and https ports.

A possible solution could look like:

values.yaml

service:
    httpPort:
        enable: true
        port: 80
        nodePort: ""

    httpsPort:
        enable: true
        port: 443
        nodePort: ""

controller-service.yaml

ports:
{{- if .Values.controller.service.httpPort.enable }}
  - port: {{ .Values.controller.service.httpPort.port }}
    targetPort: 80
    . . .
  {{- end }}
  {{- if .Values.controller.service.httpsPort.enable }}
  - port: {{ .Values.controller.service.httpsPort.port }}
    targetPort: 443
    . . .
{{- end }}

What do you think?

I do realise that this solution requires some major changes to this PR. Therefore I’d be happy to implement them. However, if you still would like to update this PR, please let me know.

Looks cool,

I want to perform these changes because they will be needed to use this ingress-controller into my company. So can I push the changes to this PR? or will be better to open a new one?

@sombralibre
great! Yes, considering the changes, it'd be better to implement them in a new PR.

I've pushed the changes to this new PR #479

Closing in favour of #479